Skip to content

Conversation

@Vectornaut
Copy link

What it does

This feature implements a gedit-style offer to load external changes, addressing issue #167. In the process, it also addresses issue #168. See #167 (comment).

How it works

When a tab gains focus (on_focus_in_view), the interface checks whether the associated file has been changed externally (editor_externally_modified). If so, the tab shows an info bar offering to reload the file (gui_external_changes_enable).

To do

Short term

Long term

  • Generalize the info bar system so that Gummi can use info bars more consistently in the future. Right now, this feature co-opts the recovery mode info bar.
  • Use the built-in gtk_source_file_is_externally_modified, like gedit does here and here, instead of the custom last_external_modtime system.

Aaron Fenyes added 5 commits March 28, 2022 21:01
This gives more sensible behavior, and more readable code too.
We're sharing the recovery mode infobar for now.
This addresses issue alexandervdm#168 (alexandervdm/gummi).
@alexandervdm alexandervdm force-pushed the master branch 2 times, most recently from 4975d07 to 0b204f0 Compare November 21, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant