Load external changes #174
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This feature implements a gedit-style offer to load external changes, addressing issue #167. In the process, it also addresses issue #168. See #167 (comment).
How it works
When a tab gains focus (
on_focus_in_view), the interface checks whether the associated file has been changed externally (editor_externally_modified). If so, the tab shows an info bar offering to reload the file (gui_external_changes_enable).To do
Short term
utils_save_confirmation_dialogandgui_external_changes_enable.on_focus_in_view.Long term
gtk_source_file_is_externally_modified, like gedit does here and here, instead of the customlast_external_modtimesystem.